Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WTF-1967]: Generate widget property types for metadata associations #106

Merged

Conversation

legio-vi-ferrata
Copy link
Contributor

@legio-vi-ferrata legio-vi-ferrata commented Sep 30, 2024

Checklist

  • Contains unit tests ✅
  • Contains breaking changes ❌
  • Compatible with: MX 🔟
  • Did you update version and changelog? ❌ (This will be done after the release.)
  • PR title properly formatted ([XX-000]: description)? ✅

This PR contains

  • Bug fix
  • Feature
  • Refactor
  • Documentation
  • Other (describe)

What is the purpose of this PR?

This PR introduces types generation for AssociationMetaData.

Relevant changes

Client types generator is adjusted to incorporate the recently developed PW API of flexible filtering over associations.

What should be covered while testing?

Testing should include, creating a AssociationMetaData property in the Widget Definition XML and verifying (after building the widget to trigger the generator) the resulting widget property TypeScript types.

@legio-vi-ferrata legio-vi-ferrata requested a review from a team as a code owner September 30, 2024 12:58
@legio-vi-ferrata legio-vi-ferrata marked this pull request as draft September 30, 2024 13:06
@legio-vi-ferrata legio-vi-ferrata marked this pull request as ready for review September 30, 2024 13:58
Copy link
Contributor

@weirdwater weirdwater left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me. We can either wait for the next release to merge, or merge now and handle the PWT separately.

@weirdwater weirdwater merged commit 56464b5 into master Oct 31, 2024
7 checks passed
@weirdwater weirdwater deleted the wtf-1967-generation-for-association-metadata-property branch October 31, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants